Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect usage of tbody #311

Merged
merged 2 commits into from Sep 8, 2022
Merged

fix: incorrect usage of tbody #311

merged 2 commits into from Sep 8, 2022

Conversation

crd477
Copy link
Contributor

@crd477 crd477 commented Sep 8, 2022

tobdy -> tbody

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

tobdy -> tbody
Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crd477 great catch! just need to fix the tests too. Thanks! 🎉

@mtbc
Copy link

mtbc commented Sep 8, 2022

👍 Thank you for fixing that slip in #307.

tobdy -> tbody
@tenshiAMD tenshiAMD changed the title fix typo fix: incorrect usage of tbody Sep 8, 2022
Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crd477 LGTM! Thanks! 🎉

@tenshiAMD tenshiAMD merged commit 531b7e1 into all-contributors:master Sep 8, 2022
@crd477 crd477 deleted the crd477-patch-1 branch September 8, 2022 16:01
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.20.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

tenshiAMD added a commit that referenced this pull request Sep 13, 2022
* origin/master: (85 commits)
  refactor: log full error stack on error (#316)
  chore: fix status badges (#315)
  docs: add JoshuaKGoldberg as a contributor for bug (#314)
  fix: incorrect usage of `tbody` (#311)
  fix: trim `nextLink` before slicing (#309)
  fix: set default value as `7` for `contributorsPerLine` (#139)
  chore(deps): bump dependencies and devDeps (#298)
  refactor: add tbody to contributors table (#307)
  docs: add Lucas-C as a contributor for doc (#306)
  fix: scriptName + improving usage messages (#305)
  docs: add vapurrmaid as a contributor (#304)
  chore(deps): CVE-2021-23337 in inquirer->lodash (#303)
  docs: add SirWindfield as a contributor (#297)
  feat: add namespaced token (#296)
  docs: add LaChapeliere as a contributor (#292)
  feat(contribution-types): add research contribution type (#291)
  docs: add darekkay as a contributor (#290)
  feat: display a meaningful error when the config file is missing (#288)
  docs: add melink14 as a contributor (#285)
  docs: add jdalrymple as a contributor (#264)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants