Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement task group associated to a Context & more #30

Merged
merged 1 commit into from May 9, 2022

Conversation

alitto
Copy link
Owner

@alitto alitto commented May 9, 2022

  • Upgrade go version to 1.8
  • Implement new method in WorkerPool to create a group of tasks associated to a context GroupContext(ctx context.Context)
  • Move TaskGroup to a separate file
  • Move tests related to task groups to a separate file

@codecov-commenter
Copy link

Codecov Report

Merging #30 (f9197db) into master (d4c09d4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines          329       373   +44     
=========================================
+ Hits           329       373   +44     
Impacted Files Coverage Δ
group.go 100.00% <100.00%> (ø)
pond.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c09d4...f9197db. Read the comment docs.

@alitto alitto force-pushed the feature/group-context branch 2 times, most recently from 583da22 to ae7aa12 Compare May 9, 2022 23:04
@alitto alitto changed the title Group context Implement task group associated to a Context May 9, 2022
@alitto alitto changed the title Implement task group associated to a Context Implement task group associated to a Context & more May 9, 2022
@alitto alitto marked this pull request as ready for review May 9, 2022 23:11
@alitto alitto merged commit 44f8f0d into master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants