Implementing Count functionality in SSCAN #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SScan to respect count
|
thanks for the PR! I'll have a look soon (vacation) |
|
Thanks! |
|
Thank you for merging this ticket! I wanted to go ahead and start using this functionality, may I get an update on when you plan on releasing a new version with these changes? |
|
I wanted to go ahead and start using this functionality, can I get an update on when you plan on releasing a new version with these changes?
Ah yeah, just made v2.23.0. Thanks!
|
BarakSilverfort
added a commit
to BarakSilverfort/miniredis
that referenced
this pull request
Jun 14, 2023
Based on the implementation for the COUNT parameter in the SSCAN implementation: alicebob#287
BarakSilverfort
added a commit
to BarakSilverfort/miniredis
that referenced
this pull request
Sep 27, 2023
Based on the implementation for the COUNT parameter in the SSCAN implementation: alicebob#287
BarakSilverfort
added a commit
to BarakSilverfort/miniredis
that referenced
this pull request
Sep 27, 2023
Based on the implementation for the COUNT parameter in the SSCAN implementation: alicebob#287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently miniredis does not utilize the count functionality , defaulting any use to 0.
This change utilizes the use of adding in the functionality to support count in SSCAN and also allowing the use of a cursor arg to be passed in as well.
Link to an issue: