Implement LPOS #286
Merged
Implement LPOS #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't know how to run the integration tests, but I manually tested integration using the redis CLI on the redis docs. Will integration tests be run through CI? |
Closed
|
Hi! Thanks for the PR! It looks good after a quick look, but I'll have a proper look soon. CI I need to approve manually says github, which I did. |
alicebob
reviewed
Aug 8, 2022
alicebob
requested changes
Aug 8, 2022
|
Thank you for the quick review! Comment resolved; please take another look. |
|
Looks good, I'll have a 2nd (awake) look again tomo. Can you squash the last three commits already? That way you get the credits. (or squash all 4 if that's easier, doesn't matter much) |
|
Squashed. |
|
Thanks! I'll make it a proper release when I've got the other open PRs in. |
|
Thank you for the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253