Extend XPENDING and add support for XGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}, XINFO {CONSUMERS,GROUPS}, XCLAIM
#281
Conversation
sandyharvie
changed the title
XGROUP {DESTROY,DELCONSUMER}, XINFO {CONSUMERS,GROUPS}, and XCLAIMXGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}, XINFO {CONSUMERS,GROUPS}, and XCLAIM
| } | ||
| } | ||
|
|
||
| // XGROUP CREATE | ||
| func (m *Miniredis) cmdXgroupCreate(c *server.Peer, cmd string, args []string) { | ||
| stream, group, id := args[1], args[2], args[3] | ||
| if len(args) != 3 && len(args) != 4 { | ||
| c.WriteError(errWrongNumber("CREATE")) |
There was a problem hiding this comment.
All errors also need a setDirty(c) (for transactions).
|
Hi! Thanks for the PR. It looks good on first glance, but I'll need some time to have a proper look. |
sandyharvie
changed the title
XGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}, XINFO {CONSUMERS,GROUPS}, and XCLAIMXPENDING and add support for XGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}, XINFO {CONSUMERS,GROUPS}, XCLAIM
|
PR looks good. I'm still trying to fix the problem with pre 1.17 Go, but I might also say the minimum version of miniredis will be 1.17 (which seems reasonable to me since it's the last version pre-generics). |
I think I've fixed the remaining issues in 65aebb7, but feel free to revert the changes if you choose to make 1.17 the minimum supported version. |
|
Now CI is happy, thanks. Can you squash all the commits? I'll have a final look then (it's a big pr :) |
sandyharvie
force-pushed
the
add-support-for-additional-stream-commands
branch
from
65aebb7
to
e3776cb
Compare
…,DELCONSUMER}`, `XINFO {CONSUMERS,GROUPS}`, `XCLAIM`
sandyharvie
force-pushed
the
add-support-for-additional-stream-commands
branch
from
e3776cb
to
41c1bec
Compare
|
thanks! |
As stated in the title, this PR adds support for the following commands:
XGROUP {CREATECONSUMER,DESTROY,DELCONSUMER}XINFO {CONSUMERS,GROUPS}XCLAIMIn addition, I've added support for
IDLEto theXPENDINGimplementation.