Fix possibility to generate duplicate IDs in XADD #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. That sounds dodgy indeed. I only had a quick look, but would it be possible to add the |
|
I thought about that but I believe the intent is that the ids should be unique across all streams. But doing our that way is still far less wrong so it's a possibility. Also I didn't look at the tests which are now failing. |
|
I updated to store the last ID in streamKey and also keeping the older check based on the last ID from the stream, which allows the tests to pass. |
The existing code is attempting to avoid duplicate IDs by checking the last ID in the queue. But if the queue is emptied and a new event added fast enough, it's possible to end up with duplicate IDs. This adds a variable to streamKey that keeps track of the last ID even when the stream itself is empty, which likely solves most cases where this could cause problems.
|
(fixed commit message) |
|
Thanks for the update. This looks OK to me. It might change the behavior of existing tests in the wild, but imo it's a valid fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code is attempting to avoid duplicate IDs by checking the
last ID in the queue. But if the queue is emptied and a new event
added fast enough, it's possible to end up with duplicate IDs.
This simply adds a global variable that ensures IDs are monotonically
increasing across all streams.