Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid resposne of COMMAND #273

Merged
merged 1 commit into from Jun 22, 2022
Merged

Conversation

zsh1995
Copy link
Contributor

@zsh1995 zsh1995 commented Jun 20, 2022

When I use github.com/go-redis/redis/v8 redis.Command would return a error:

redis: can't parse array reply: "$9440"

The reason is that WriteBulk append $len(str) in front of the data. Correct response of Command should be $len(commands).

@alicebob
Copy link
Owner

alicebob commented Jun 20, 2022 via email

@alicebob alicebob merged commit 80cb163 into alicebob:master Jun 22, 2022
@alicebob
Copy link
Owner

Thanks! Good catch.

pje added a commit to pje/miniredis that referenced this pull request Apr 17, 2023
alicebob added a commit that referenced this pull request Apr 17, 2023
Bring back the fix for COMMAND responses introduced in #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants