[miniredis] Add maxCullLen to minirdis.Dump() #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicebob
reviewed
May 20, 2022
miniredis.go
Outdated
| @@ -340,25 +340,36 @@ func (m *Miniredis) Server() *server.Server { | |||
| return m.srv | |||
| } | |||
|
|
|||
| type DumpOptions struct { | |||
| maxCullLen int | |||
There was a problem hiding this comment.
That will have to be exported: MaxCullLen.
There was a problem hiding this comment.
No longer relevant: using a global var
|
Thanks for the PR! Did you consider making it a global var? |
|
@alicebob Hey. Thanks for the quick reply! I agree that a global var is easier and cleaner to work with. Done and done. Lemme know how this looks now |
|
Thanks for the PR! It's merged, will make it a proper release in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. Thanks for the fantastic project!
Currently,
miniredis.Dump()limits the string length to 80. During unit tests sessions, it's really useful to know the contents of the entire DB while inside a debugger (i.e., delve).The change I made doesn't break the API; it just makes maxLen modifiable.
Thanks again!