Implement LMOVE #245
Merged
Implement LMOVE #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Wed, Jan 12, 2022 at 07:16:29PM -0800, btwear wrote:
LMOVE command implementation with tests. Most of work is based on RPOPLPUSH.
You can view, comment on, or merge this pull request online at:
Thanks! I'll have a look soon. Could you add some simple tests to the relevant test in ./integration/ as well?
|
|
@alicebob |
|
What a funny redis command. PR looks good when doing a basic read over it, will have a proper look soon. |
|
great PR, thanks! Merged in master, will make it a release it later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found there is no LMOVE command currently, so I implement it with tests.
Most of my works are based on RPOPLPUSH implementation.