Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua cjson.decode("null") returns nil instead of cjson.null #127

Open
vk-outreach opened this issue Dec 18, 2019 · 1 comment
Open

lua cjson.decode("null") returns nil instead of cjson.null #127

vk-outreach opened this issue Dec 18, 2019 · 1 comment

Comments

@vk-outreach
Copy link
Contributor

In production redis, it looks like cjson.decode("null") returns cjson.null whereas the lua cjson in miniredis returns nil.

Maybe gopher-lua should be updated to match redis? The change involved seems a bit deep though (requires changing gopher-lua to return a special sentinel value and making cjson.null also return that sentinel value).

@alicebob
Copy link
Owner

Thanks,

miniredis already uses a fork, maybe you can have a look? https://github.com/alicebob/gopher-json

(I don't remember the reason we needed the fork, will have to look that up another day)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants