Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixed for compatible jdk8 default method when deserialize using asm #947

Merged
merged 1 commit into from Dec 12, 2016

Conversation

CharkeyQK
Copy link
Contributor

jdk1.8 使用 asm 序列化、反序列化时报错 “java.lang.IncompatibleClassChangeError”,@wenshao 的commit bug fixed for compatible jdk8 default method. issue #289 #830 #935 修复了序列化时的错误,反序列化的场景未修复此bug。

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2016

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Dec 11, 2016

Current coverage is 91.42% (diff: 75.00%)

Merging #947 into master will decrease coverage by 0.01%

@@             master       #947   diff @@
==========================================
  Files           114        114          
  Lines         16713      16715     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       3927       3928     +1   
==========================================
  Hits          15281      15281          
- Misses          693        694     +1   
- Partials        739        740     +1   

Powered by Codecov. Last update d29b6dd...8a1ae11

@wuwen5
Copy link
Contributor

wuwen5 commented Dec 11, 2016

可以提供下能重现的反序列化失败的测试代码吗?

之前序列化的问题确重现了且已经修复了,你说的这个好像没法重现哦,什么场景会触发呢?

@CharkeyQK
Copy link
Contributor Author

fastjson-test

POST /offerCatalog/qry HTTP/1.1
Content-Type: application/json

{"value":{"id":1}}

错误日志:

java.lang.IncompatibleClassChangeError: Found interface com.charkey.fastjson.domain.IBaseBean, but class was expected

@wenshao wenshao merged commit 3bb7773 into alibaba:master Dec 12, 2016
@wenshao
Copy link
Member

wenshao commented Dec 12, 2016

问题重现并且这个patch已解决问题,谢谢你提交patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants