Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialized filter plugins #1483

Open
winder opened this issue Feb 22, 2023 · 0 comments
Open

Specialized filter plugins #1483

winder opened this issue Feb 22, 2023 · 0 comments
Labels
new-feature-request Feature request that needs triage Team Lamprey

Comments

@winder
Copy link
Contributor

winder commented Feb 22, 2023

Problem

The filter plugin's flexibility makes it complicated. There should be a series of plugin's which act as predefined filters.

  • Filter by account. This would add an any filter for all the different places an account can be set.
  • Filter by application IDs.
  • Filter by asset IDs.

Solution

Thin wrappers around the existing filter plugin.

Question

Should the "match all in group" and "search inner transactions" be surfaced as settings or automatically enabled?

The plugin pipeline is applied one by one, which means multiple instances of filter plugin's would only return transactions which match ALL filters. This may be unexpected, so an error should be returned if multiple filter plugins are enabled. (A global counter in the init function?

Priority

nice-to-have.

@winder winder added the new-feature-request Feature request that needs triage label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature-request Feature request that needs triage Team Lamprey
Projects
None yet
Development

No branches or pull requests

2 participants