Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): write an annotated git tag #989

Merged
merged 1 commit into from Jan 9, 2023
Merged

fix(tags): write an annotated git tag #989

merged 1 commit into from Jan 9, 2023

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 9, 2023

Some other tools like git describe (used by lerna) will only return annotated tags. As well, the git documentation (link) primarily documents writing annotated tags.

This commit changes the behaviour of tags written by shipjs to write annotated tags

Some other tools like `git describe` (used by lerna) will only return annotated tags. As well, the git documentation ([link](https://git-scm.com/book/en/v2/Git-Basics-Tagging)) primarily documents writing annotated tags.

This commit changes the behaviour of tags written by shipjs to write annotated tags
@Haroenv Haroenv requested a review from dhayab January 9, 2023 13:06
@Haroenv Haroenv requested a review from dhayab January 9, 2023 13:22
@Haroenv Haroenv merged commit 5c19401 into main Jan 9, 2023
@Haroenv Haroenv deleted the fix/tag-annotation branch January 9, 2023 13:32
@vinayakkulkarni
Copy link
Contributor

This release is causing issue while creating git tags:

Screenshot 2023-01-10 at 4 39 00 PM

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 10, 2023

We updated the documentation right after to clarify that you need credentials :) #991. As shipjs is in prerelease this wasn't a breaking change, hope you understand!

@vinayakkulkarni
Copy link
Contributor

:smh:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants