Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Control automated check have failed #1173

Open
pixelastic opened this issue Nov 3, 2023 · 2 comments
Open

API Control automated check have failed #1173

pixelastic opened this issue Nov 3, 2023 · 2 comments

Comments

@pixelastic
Copy link
Collaborator

Seems like the API Control tests we moved into their own weekly CRON job has had its first fail: https://github.com/algolia/npm-search/actions/runs/6704941688/job/18218376954. This is partly expected, as those tests are flaky.

The action should also have automatically created this issue, but I misconfigured the GITHUB_TOKEN env variable and it didn't.

As for the test itself, we could simply increase the timeout, but I think @Haroenv mentioned also adding a retry mechanism. Any preference? @MartinKolarik have you seen just being slow and waiting long would work, or does it make more sense to retry?

@Haroenv
Copy link
Collaborator

Haroenv commented Nov 3, 2023

I think just trying the whole test a second time, with a little time between would be ideal in this case

@MartinKolarik
Copy link
Collaborator

I suggest at least five attempts in total with up to a few minutes between each. The API is occasionally very slow or just straight up failing with 502 errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants