Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient height modal dropdown on mobiles #984

Closed
lex111 opened this issue Nov 12, 2020 · 5 comments
Closed

Insufficient height modal dropdown on mobiles #984

lex111 opened this issue Nov 12, 2020 · 5 comments
Labels

Comments

@lex111
Copy link
Contributor

lex111 commented Nov 12, 2020

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Try searching for something like "doc" on https://v2.docusaurus.io/ and you will see at the bottom of the search modal big empty space that should be taken up by the search results.

Via emulated mobile device in Chome:

image

On Google Pixel 3a XL via BrowserStack:

image

On iPhone 11 Pro via BrowserStack:

image

GIF:

ezgif com-gif-maker (11)

What is the expected behavior?

image

cc @francoischalifour

@francoischalifour
Copy link
Member

Hey @lex111! We fixed this issue in a8fb063 but didn't release it yet. I'll send a PR to Docusaurus to upgrade the version once we release (by next week).

@lex111
Copy link
Contributor Author

lex111 commented Nov 12, 2020

Great, but what about another bug in horizontal orientation, is it fixed? Notice the footer panel position, it overlaps the search results.

ezgif com-gif-maker (12)

@lex111
Copy link
Contributor Author

lex111 commented Nov 20, 2020

@francoischalifour any news?

@francoischalifour
Copy link
Member

francoischalifour commented Nov 20, 2020

Sorry—I got caught up on other projects this week.

We've planed some time next week to pack a new release. I'll keep you updated.

@francoischalifour
Copy link
Member

Fix released in v3.0.0-alpha.29.

I sent a PR to Docusaurus: facebook/docusaurus#3819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants