This repository was archived by the owner on Jul 11, 2023. It is now read-only.
feat(searchForFacetValues): fall back to client.search if it's present #906
+91
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client.search with `type: 'facet', facet, params: { facetQuery }` can be used in v4 onwards as an alternative to client.searchForFacetValues, meaning the client.searchForFacetValues method can be removed in a future major version.
Unfortunately the JS client v3 doesn't support type "facet" for multi-index search because it manually decides which keys are used in the post object: https://github.com/algolia/algoliasearch-client-javascript/blob/v3/src/AlgoliaSearchCore.js#L638-L654
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 423173a:
|
dhayab
reviewed
May 17, 2022
dhayab
approved these changes
May 17, 2022
This comment was marked as outdated.
This comment was marked as outdated.
dhayab
approved these changes
Jun 16, 2022
francoischalifour
approved these changes
Jun 17, 2022
Haroenv
added a commit
that referenced
this pull request
Jun 20, 2022
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Jun 20, 2022
This is done by updating the helper minimal dependency and thus includes algolia/algoliasearch-helper-js#906 and algolia/algoliasearch-helper-js#911
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Jun 20, 2022
This is done by updating the helper minimal dependency and thus includes algolia/algoliasearch-helper-js#906 and algolia/algoliasearch-helper-js#911
dhayab
added a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
algolia/algoliasearch-helper-js#906) client.search with `type: 'facet', facet, params: { facetQuery }` can be used in v4 onwards as an alternative to client.searchForFacetValues, meaning the client.searchForFacetValues method can be removed in a future major version. Unfortunately the JS client v3 doesn't support type "facet" for multi-index search because it manually decides which keys are used in the post object: https://github.com/algolia/algoliasearch-client-javascript/blob/v3/src/AlgoliaSearchCore.js#L638-L654 Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* feat(searchForFacetValues): fall back to client.search if it's present (algolia/algoliasearch-helper-js#906) algolia/algoliasearch-helper-js@297f778 * fix(requests): send a sorted object of parameters (algolia/algoliasearch-helper-js#911) algolia/algoliasearch-helper-js@3b3dc97
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.search with
type: 'facet', facet, params: { facetQuery }can be used in v4 onwards as an alternative to client.searchForFacetValues, meaning the client.searchForFacetValues method can be removed in a future major version.Unfortunately the JS client v3 doesn't support type "facet" for multi-index search because it manually decides which keys are used in the post object: https://github.com/algolia/algoliasearch-client-javascript/blob/v3/src/AlgoliaSearchCore.js#L638-L654
FX-1432