Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(ts): document renderingContent #823

Merged
merged 2 commits into from Jun 10, 2021
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jun 9, 2021

Note: while the format will not change, it's not yet live

DX-2116

Note: while the format will not change, it's not yet live
@Haroenv Haroenv requested review from a team, tkrugg and shortcuts and removed request for a team June 10, 2021 07:54
Haroenv added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 10, 2021
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks consistent with what is describe in the RFC and the implementation!

(My suggestions is only if we change the naming in #822 (comment))

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
Haroenv added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 10, 2021
* feat(ts): document renderingContent

DX-2066

see also the helper PR: algolia/algoliasearch-helper-js#823

* Update packages/client-search/src/types/SearchResponse.ts
@Haroenv Haroenv merged commit 7b176a7 into develop Jun 10, 2021
@Haroenv Haroenv deleted the feat/ts-rendering-content branch June 10, 2021 15:06
Haroenv added a commit that referenced this pull request Jun 10, 2021
 * feat(ts): document renderingContent (#823) 7b176a7
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
)

* feat(ts): document renderingContent

Note: while the format will not change, it's not yet live

* Apply suggestions from code review

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants