This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(ts): make queryID optional #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
requested review from
a team,
yannickcr and
francoischalifour
and removed request for
a team
francoischalifour
approved these changes
Jan 13, 2021
Haroenv
approved these changes
Jan 13, 2021
Haroenv
changed the title
eunjae-lee
added a commit
that referenced
this pull request
Feb 10, 2021
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* chore: update yarn.lock algolia/algoliasearch-helper-js@ba912f9 * fix(ts): add types for smart sort (algolia/algoliasearch-helper-js#809) algolia/algoliasearch-helper-js@7fa7528 * fix(ts): make queryID optional (algolia/algoliasearch-helper-js#806) algolia/algoliasearch-helper-js@5ec4e86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
queryIDoptionable. It's given only whenclickAnalytics: true.