fix(indexing): replaceAllObjects blocked if called for non-existent index #699
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
reviewed
Aug 25, 2022
samouss
approved these changes
Aug 26, 2022
Co-authored-by: Samuel Vaillant <samuel.vllnt@gmail.com>
VladislavFitz
force-pushed
the
fix/replace-non-existent-index-block
branch
from
62b1f3a to
02eb3c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Add a check if the index exists in the
ReplaceAllObjectsfunction body.If the index doesn't exist, only the
SaveObjectsoperation will be executed which creates the index and saves the provided objects into it.What problem is this fixing?
ReplaceAllObjectshangs indefinitely if the index does not exist (#694). This happens due to infiniteCopyIndextask when called for a non-existent index: the task successfully starts successfully but never accomplishes.