Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid logging sensitive headers #414

Closed
andrewhickman opened this issue Sep 1, 2021 · 0 comments · Fixed by #415
Closed

Avoid logging sensitive headers #414

andrewhickman opened this issue Sep 1, 2021 · 0 comments · Fixed by #415

Comments

@andrewhickman
Copy link
Contributor

Currently the entire HTTP prelude is printed at debug level, including all headers

ureq/src/unit.rs

Line 410 in a1d7009

debug!("writing prelude: {}", String::from_utf8_lossy(&prelude));

It would be nice to avoid printing sensitive headers like Authorization
@andrewhickman andrewhickman mentioned this issue Sep 1, 2021
Merged
@jsha jsha closed this as completed in #415 Oct 5, 2021
jsha pushed a commit that referenced this issue Oct 5, 2021
@andrewhickman
Redact sensitive headers when logging prelude (#415)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
eb78813 
Closes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redact sensitive headers when logging prelude
1 participant
@andrewhickman