Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest hash never change #7

Open
allenwq opened this issue Mar 11, 2017 · 3 comments
Open

Manifest hash never change #7

allenwq opened this issue Mar 11, 2017 · 3 comments

Comments

@allenwq
Copy link

allenwq commented Mar 11, 2017

Followed webpack guide and defined a manifest.js for holding the webpack runtime. but the hash of the manifest never changes after I used this plugin. By right it should change every time when vendor or app changes.

Any ideas ?

our config:

entry: {
    app: ['babel-polyfill', './app/index'],
    vendor: ['dep1', 'dep2'],
  },
  plugins: [
    new webpack.IgnorePlugin(/__test__/),
    new WebpackChunkHash(),
    new webpack.optimize.CommonsChunkPlugin({
      names: ['vendor', 'manifest'],
    }),
  ],

REF: https://webpack.js.org/guides/caching/#deterministic-hashes

@edorivai
Copy link

Seeing a similar problem. The screenshot shows the diff between two webpack build outputs. I ensured I added an async chunk between the builds, which shows up as chunk 55. We see the main chunk correctly updating (that's where I added the async import), and we see that he manifest clearly changed as well; the filesize grew. This all makes sense, though as @allenwq points out, the manifest hash does not update.

image

@edorivai
Copy link

edorivai commented Apr 10, 2017

I've setup a simple test for this:

https://github.com/edorivai/webpack-chunk-test

Comment/uncomment the async import in main.js and you'll see that the chunkhash of the manifest does not update.

@DCtheTall
Copy link

DCtheTall commented Jul 14, 2017

Bumping this issue.

Our production app at work used this module for adding hashes and uploading new scripts to S3, it was not updating hashes after changes to our Babel code.

Once we commented this module out of our webpack plugins and used webpack-md5-hash module instead, the hashes changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants