Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ETA calculation #174

Open
alexheretic opened this issue Jan 12, 2024 · 4 comments · Fixed by #175
Open

Add custom ETA calculation #174

alexheretic opened this issue Jan 12, 2024 · 4 comments · Fixed by #175
Labels
enhancement New feature or request

Comments

@alexheretic
Copy link
Owner

Current eta provided by upstream indicatif has issues with slow ticks of some encode jobs. It also struggles with switching between different rates of encoding and VMAF part of a single job.

A custom eta calculation tailored for ab-av1 usage may do better.

@alexheretic alexheretic added the enhancement New feature or request label Jan 12, 2024
@alexheretic
Copy link
Owner Author

alexheretic commented Jan 12, 2024

One workaround could be to increase granularity from using encoding progress seconds / total_seconds to µs / total_µs to provide the upstream algorithm more regular integer progress.

@alexheretic
Copy link
Owner Author

#175 improves some scenarios but I can still see it eta rocketing up to years when it should be minutes.

@alexheretic alexheretic reopened this Jan 14, 2024
@zedstate
Copy link

Why not base the ETA on frames per second?

@alexheretic
Copy link
Owner Author

Why not base the ETA on frames per second?

Indeed. Currently we use upstream eta calc based on progress bar updates. So yes replacing that with a custom calculation we can base it on ffmpeg reported rate. We can also account for vmaf rate & encoding rate in crf-searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants