Fix usage writing when using custom version flag #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 99.17% 99.73% +0.55%
==========================================
Files 5 5
Lines 731 744 +13
==========================================
+ Hits 725 742 +17
+ Misses 3 1 -2
+ Partials 3 1 -2 ☔ View full report in Codecov by Sentry. |
hhromic
changed the title
hhromic
changed the title
hhromic
force-pushed
the
better-version-v2
branch
from
f7b0444
to
851ff4c
Compare
|
Rebased on top of the latest |
|
@hhromic This looks good but I need to look closer because there are quite a few changes (even ignoring the tests -- thanks for adding those) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alexflint , this is a small follow-up to PR #223 :)
I realized that I forgot to update the write usage function, and it was still printing the output of
Version()even if a custom--versionflag spec is present in the arguments. This is now also fixed and I added more unit tests for help/usage writing.I also took the opportunity to improve a bit the way version flag specs are scanned for both usage and help writing.
I belive that this PR now fully addresses issue #171 because, when using a custom
--versionflag, the builtin version string (if any) is not printed anymore in usage and errors.Fixes #171