port/addr is local dir #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch perhaps should be renamed in a future breaking release to "addr", since it doesn't HAVE to be a port) can actually be a local directory (ex. "file:///") and ngrok will serve up a fileserver. Added test. - Preparing for 4.1.4 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #50, where
addrcan actually be a local directory (ex. "file:///") and ngrok will serve up a fileserver.addris actually represented bypyngrok'sportvar onngrok.connect(), which perhaps should be revisited in a future, breaking release and renamed toaddrsince it doesn't just need to be aport. Not addressed in this PR, however, since we only want non-breaking changes.This change is