-
Notifications
You must be signed in to change notification settings - Fork 192
Make datetime.rs structs and fields public #431 #439
Conversation
LGTM |
Can you fill out the documentation for each field and what it corresponds to for datetimes as specified by toml? |
I think I can gather the information to do that. I'll take a look. |
@alexcrichton I added some docs, hope you like 'em! |
Thanks! |
I've tested this in rtoml samuelcolvin/rtoml#30. It's working great. Thank you both. |
|
||
/// Offset between local time and UTC | ||
Custom { | ||
/// Hours: -12 to +12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very minor, but I happened to notice that these docs are slightly incorrect: this can be as large as +13 or even +14 https://en.wikipedia.org/wiki/UTC%2B14:00 for real timezones, on some Pacific islands.
A special mention for Chatham Islands during DST, where the offset is +13:45.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #444
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huonw Nice find! This made my day on GitHub for sure!
* test out toml-rs/toml-rs#439 * remove git install of toml-rs
In issue #431, @samuelcolvin wrote:
Then @alexcrichton replied: