This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
Allow empty table keys #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsloan
force-pushed
the
allow-empty-table-keys
branch
2 times, most recently
from
52ce649
to
e5bc5bc
Compare
|
Looks like empty keys were quite intentionally disallowed. I can see this being diagnostically nice for many applications, but toml allows it, so I think it's better to match the spec. |
Quoting https://github.com/toml-lang/toml/tree/68076ffc6d9a150d48f1df964551283542ad47bc#user-content-keys > A bare key must be non-empty, but an empty quoted key is allowed (though discouraged). See also the discussion in toml-lang/toml#432
mgsloan
force-pushed
the
allow-empty-table-keys
branch
from
e5bc5bc
to
f74715c
Compare
|
Note that the reason this was found by a property test is that the serializer will happily output invalid toml when serializing a table with an empty key. |
|
Could this fix be merged? The current behavior clearly goes against the spec. |
ehuss
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue by writing a roundtrip property test using quickcheck - master...mgsloan:roundtrip-property-test .
Quoting https://github.com/toml-lang/toml/tree/68076ffc6d9a150d48f1df964551283542ad47bc#user-content-keys
See also the discussion in toml-lang/toml#432