Add support for readers that implement Seek (#218) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Oct 4, 2021
alexcrichton
reviewed
Oct 5, 2021
alexcrichton
reviewed
Oct 5, 2021
| done: false, | ||
| next: 0, | ||
| raw: false, | ||
| }) | ||
| } | ||
|
|
||
| fn _unpack(&mut self, dst: &Path) -> io::Result<()> { | ||
| fn _unpack(&'a mut self, dst: &Path) -> io::Result<()> { |
There was a problem hiding this comment.
I think this 'a may no longer be necessary?
There was a problem hiding this comment.
rustc seems to need this to determine the lifetime of the seekable_archive argument when calling _entries().
`Archive::entries_with_seek` can be used to get an iterator over entries for a reader that implements `Seek`.
|
Ok looks great to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archive::newrequires onlyReadfor backward-compatibility, whileArchive::new_from_seekcan be used with readers that also implementSeek, to allow more efficient skipping over file contents.