Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export internals for use in async-tar #255

Closed
danieleades opened this issue Jul 21, 2021 · 4 comments
Closed

export internals for use in async-tar #255

danieleades opened this issue Jul 21, 2021 · 4 comments

Comments

@danieleades
Copy link
Contributor

async-tar is in large part a copy-paste of the internals of this crate. Over time the implementations are drifting apart (for example async-tar apparently supports redox as a target).

this seems a bit daft to me. I wanted to gauge whether there was any appetite for refactoring this crate so that some of the internals could be imported in async-tar instead of being copied.

for example the header.rs implementation is damn near identical (see #254)

@alexcrichton
Copy link
Owner

Sorry I don't know much about async-tar or the history there. I think it's fine to export more functionality from this crate but I would still want a well-designed API with pieces that are thought through well and make sense. I don't want to "just make everything pub", for example.

@danieleades
Copy link
Contributor Author

Sorry I don't know much about async-tar or the history there. I think it's fine to export more functionality from this crate but I would still want a well-designed API with pieces that are thought through well and make sense. I don't want to "just make everything pub", for example.

I was thinking more along the lines of splitting out some of the types into a separate crate and publishing that, rather than just adding pubs everywhere

@alexcrichton
Copy link
Owner

Personally I would prefer to not maintain a separate crate for that purpose.

@danieleades
Copy link
Contributor Author

It would be a separate crate in the same repo, as a workspace. But I understand the reservations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants