Fix cross-compiling ios targets with cmake 3.14 as #88 states #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloucks
reviewed
Mar 25, 2020
| "x86_64" => Some("x86_64".to_owned()), | ||
| _ => { | ||
| eprintln!( | ||
| "Warning: unknown architecture for target: {}", |
There was a problem hiding this comment.
Should these warnings use the cargo:warning=MESSAGE format?
|
Looks good to me, thanks so much for helping to land this! I'm gonna go ahead and merge this and further iteration can happen in-tree. |
alexcrichton
added a commit
that referenced
this pull request
May 18, 2020
This was referenced May 18, 2020
Dushistov
added a commit
to Dushistov/cmake-rs
that referenced
this pull request
Jun 3, 2020
…st-lang#88 states (rust-lang#93)"" This reverts commit 9a53f43.
Dushistov
added a commit
to Dushistov/cmake-rs
that referenced
this pull request
Jun 9, 2020
…st-lang#88 states (rust-lang#93)"" This reverts commit 9a53f43.
MichaelHills
pushed a commit
to MichaelHills/cmake-rs
that referenced
this pull request
Sep 13, 2020
rust-lang#93) * Rename target variable to target_triple * Remove a bit of code duplication * Add GenericTarget with several override points * Add support for cross-compiling Apple targets with cmake 3.14 * Removed lazy_static and regex Co-authored-by: Kyle Fleming <kyle@kylefleming.net>
Dushistov
added a commit
to Dushistov/cmake-rs
that referenced
this pull request
Feb 12, 2021
rust-lang#93) * Rename target variable to target_triple * Remove a bit of code duplication * Add GenericTarget with several override points * Add support for cross-compiling Apple targets with cmake 3.14 Co-authored-by: simlay <simlay@users.noreply.github.com> Co-authored-by: Kyle Fleming <kyle@kylefleming.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the combination of #88 and addresses some of the comments from #88.
At the moment of authorship, f1c7a6a is the only difference between this PR and #88 to parse the arguments in the
filter_compiler_argsimplementation forAppleTarget.