Always specify architecture for x86_64 / aarch64 Darwin #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a few benefits. The first is that it's not required to specify `CFLAGS_aarch64_apple_darwin='-arch arm64'` when cross-compiling from x86_64 to aarch64 (or `-arch x86_64` the other way around). Another is that the `cc` frontend performs some snooping of the process hierarchy — if any parent is running in the Rosetta emulation layer, it will default to targeting x86_64. This means that running `cc` on a Developer Transition Kit is likely to suddenly and magically revert to x86_64 if any piece of the chain is emulated (`rustc`, `cargo`, `rustup`, the shell, even the terminal emulator!). It's likely that the `-m64` option is superfluous with these new options, but I don't see any harm in it either.
31 tasks
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few benefits. The first is that it's not required to
specify
CFLAGS_aarch64_apple_darwin='-arch arm64'whencross-compiling from x86_64 to aarch64 (or
-arch x86_64the otherway around).
Another is that the
ccfrontend performs some snooping of theprocess hierarchy — if any parent is running in the Rosetta emulation
layer, it will default to targeting x86_64. This means that running
ccon a Developer Transition Kit is likely to suddenly and magicallyrevert to x86_64 if any piece of the chain is emulated (
rustc,cargo,rustup, the shell, even the terminal emulator!).It's likely that the
-m64option is superfluous with these newoptions, but I don't see any harm in it either.