Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -nologo command-line option to Microsoft assembler. #525

Merged
merged 1 commit into from Jul 6, 2020

Conversation

dot-asm
Copy link
Contributor

@dot-asm dot-asm commented Jul 3, 2020

Hi,

I'd like to make a case for adding -nologo to Microsoft assembler command line. Trouble is that cargo treats the logo as warning, and worst part is that it's "sticky." "Sticky" in sense that once object files are generated and you re-run 'cargo build' for whatever different reason, it will keep showing the logo (multiple if assembler was invoked several times) tagged with "warning" without actually executing the assembler.

Cheers.

@alexcrichton
Copy link
Member

Seems reasonable to me!

@alexcrichton alexcrichton merged commit 5e6bb36 into rust-lang:master Jul 6, 2020
@dot-asm
Copy link
Contributor Author

dot-asm commented Jul 7, 2020

Thanks!

@dot-asm dot-asm deleted the ml-nologo branch July 7, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants