Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wr-c++ instead of vx-cxx #432

Merged
merged 1 commit into from Aug 12, 2019
Merged

Conversation

BaoshanPang
Copy link

We decide to use the name "wr-c++" for the compiler driver.

@alexcrichton alexcrichton merged commit f99a424 into rust-lang:master Aug 12, 2019
@BaoshanPang
Copy link
Author

@alexcrichton

Thanks for approved and merged the code.
Can you help to label it so we can pick it up with "cargo update"?

Thanks,
Baoshan

@alexcrichton
Copy link
Member

Sure thing, done!

@BaoshanPang
Copy link
Author

@alexcrichton

Appreciate your quick response.
But I made a big mistake, I typed "wr-c++" to "wr=c++", I need to create a new PR to fix it.
I am very sorry to bother you again.

Thanks,
Baoshan

@BaoshanPang
Copy link
Author

@alexcrichton

Actually the code in my branch is correct, but the commit "0187762" changed "wr-c++" to "wr=c++" for some reason.

Can you help to fix it?

Thanks,
Baoshan

@alexcrichton
Copy link
Member

Oops my bad, I typo'd the merge there

@alexcrichton
Copy link
Member

(published a fixed version)

@BaoshanPang
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants