Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Multiple ignore params get clobbered by the last one #118

Open
willsmanley-uber opened this issue Jan 18, 2023 · 4 comments
Open

Bug: Multiple ignore params get clobbered by the last one #118

willsmanley-uber opened this issue Jan 18, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@willsmanley-uber
Copy link

willsmanley-uber commented Jan 18, 2023

Describe the bug
In type-coverage core, you can pass multiple ignore params and they will all be honored. In this wrapper, only the last ignore param is honored.

To Reproduce
Use two separate ignore params. Only the last one will be ignored.

Expected behaviour
Both file globs should be ignored.

@willsmanley-uber willsmanley-uber added the help wanted Extra attention is needed label Jan 18, 2023
@willsmanley-uber
Copy link
Author

@alexcanessa FYI, just wanted to get your thoughts here

@wolverineks
Copy link

@willsmanley-uber i was able to get it to work using package.json options
https://github.com/plantain-00/type-coverage#config-in-packagejson

@luisrudge
Copy link

yeah, I'm having this issue as well when using the CLI. I can't use the package.json option because I have multiple package.json files in my repo.

@alexcanessa alexcanessa added bug Something isn't working good first issue Good for newcomers and removed help wanted Extra attention is needed labels Oct 17, 2023
@alexcanessa
Copy link
Owner

Ok thanks @luisrudge.
Not sure if you'd be keen to contribute to the repo? Otherwise I'll see what I can do in the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants