(MAINT) Respect LinkTitle in page metadata #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the partial for determining a page title used the `Title` property of a page, if present, or humanized and titleized the file name if not. It did not use the `LinkTitle` property at all (defined in the [front matter][01]). According to the [menu documentation][02]: > The following order is used to determine an Identifier: > > `.Name > .LinkTitle > .Title` > > This means that `.Title` will be used unless `.LinkTitle is present, > etc. Similar, the documentation for [menu entry variables][03] states: > The `name` key, if set for the menu entry, sets this value. If that > key is not set, and if the menu entry is set in a page front-matter, > this value defaults to the page's `.LinkTitle`. Together, these imply that if `.LinkTitle` is specified, it should be preferred over `.Title` for the generated nav menu. [01]: https://gohugo.io/content-management/front-matter/ [02]: https://gohugo.io/content-management/menus/#nesting [03]: https://gohugo.io/variables/menus/#menu-entry-variables
|
Related to #476. |
alex-shpak
approved these changes
Oct 5, 2022
|
👍 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the partial for determining a page title used the
Titleproperty of a page, if present, or humanized and titleized the file name if not.It did not use the
LinkTitleproperty at all (defined in the front matter). According to the menu documentation:Similar, the documentation for menu entry variables states:
Together, these imply that if
.LinkTitleis specified, it should be preferred over.Titlefor the generated nav menu.