Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for BookCollapseSectionLevel #418

Closed
egonelbre opened this issue Feb 11, 2022 · 4 comments
Closed

Add parameter for BookCollapseSectionLevel #418

egonelbre opened this issue Feb 11, 2022 · 4 comments

Comments

@egonelbre
Copy link

For larger number of content it would be nice to specify a level where to automatically collapse pages, rather than specifying bookCollapseSection: true them individually to each item.

Note: I can try figure out an implementation, if it's seems suitable.

@alex-shpak
Copy link
Owner

Hi!
It was discussed before, can't find that issue now.
But, my conclusion was that thoose parameters will be too specific, and I try to avoid adding many configuration parameters in theme, less paramteres will help be maintaning it.

BookCollapseSectionLevel then will become BookCollapseSectionLevelFrom and BookCollapseSectionLevelToo and so on, as some users want to collaps top 3, other bottom 3, etc.

So I think it's better to keep it as it is.

@alex-shpak
Copy link
Owner

ah, here it is #340

@egonelbre
Copy link
Author

Understandable, I definitely love the minimalist approach in hugo-book and wouldn't want to compromise it. I'll close the issue.

I was able to write custom menu-filetree that handles it, so it's not an hinderance for me.

@egonelbre
Copy link
Author

Ah, btw. an alternative would be to let people specify BookCollapseSection at the site level. That way it wouldn't introduce a new concept, but allows to define the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants