Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong favicon type #393

Open
raspopov opened this issue Nov 7, 2021 · 2 comments
Open

Wrong favicon type #393

raspopov opened this issue Nov 7, 2021 · 2 comments

Comments

@raspopov
Copy link
Contributor

raspopov commented Nov 7, 2021

In the file: layouts\partials\docs\html-head.html line 13:

<link rel="icon" href="{{ "favicon.png" | relURL }}" type="image/x-icon">

has wrong type attribute, it must be either image/png or file type must be .ico correspondingly.

P.S. Also in the other themes I noticed a favicon stuff placed in the separate layouts\partials\favicon.html file.

@alex-shpak
Copy link
Owner

Hi!
Does it case some issue apart from warning? I remember I was trying to make it quite compatible without using ico file, tho, I already don't remember what was the issue.

Tho, we can move havicon template into own partial, not a big deal

@raspopov
Copy link
Contributor Author

raspopov commented Nov 9, 2021

You can use this https://realfavicongenerator.net/favicon_checker to feel the complexity and misfortune of the fate of modern website favicon. 😔 I start thinking about auto-generating the missed favicon sizes by Hugo in the some sort of partial template. Recommended sizes are 16x16, and 32x32 for legacy Windows, 120x120 for Android, 180x180 for Apple etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants