From 644bbd57c8f034c5bba610236a94c1ed9f878f1d Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Mon, 13 Feb 2023 12:02:28 -0600 Subject: [PATCH] refactor(examples): upgrade to Very Good Analysis 4.0.0 (#537) --- .github/workflows/examples_counter.yaml | 1 + .github/workflows/examples_echo.yaml | 1 + .github/workflows/examples_hello_world.yaml | 2 +- .github/workflows/examples_kitchen_sink.yaml | 1 + .github/workflows/examples_todos.yaml | 2 ++ .github/workflows/examples_web_socket_counter.yaml | 1 + examples/counter/analysis_options.yaml | 2 +- examples/counter/pubspec.yaml | 2 +- examples/echo/analysis_options.yaml | 2 +- examples/echo/pubspec.yaml | 2 +- examples/hello_world/analysis_options.yaml | 2 +- examples/hello_world/pubspec.yaml | 2 +- examples/kitchen_sink/analysis_options.yaml | 2 +- examples/kitchen_sink/pubspec.yaml | 2 +- examples/todos/analysis_options.yaml | 2 +- .../in_memory_todos_data_source/analysis_options.yaml | 2 +- .../todos/packages/in_memory_todos_data_source/pubspec.yaml | 4 ++-- .../todos/packages/todos_data_source/analysis_options.yaml | 2 +- .../todos/packages/todos_data_source/lib/src/models/todo.dart | 2 +- examples/todos/packages/todos_data_source/pubspec.yaml | 4 ++-- examples/todos/pubspec.yaml | 2 +- examples/web_socket_counter/analysis_options.yaml | 2 +- examples/web_socket_counter/pubspec.yaml | 2 +- 23 files changed, 26 insertions(+), 20 deletions(-) diff --git a/.github/workflows/examples_counter.yaml b/.github/workflows/examples_counter.yaml index ef5c48ca7..8ab06b1b4 100644 --- a/.github/workflows/examples_counter.yaml +++ b/.github/workflows/examples_counter.yaml @@ -7,6 +7,7 @@ concurrency: on: pull_request: paths: + - "examples/counter/pubspec.yaml" - "examples/counter/routes/**" - "examples/counter/lib/**" - "examples/counter/test/**" diff --git a/.github/workflows/examples_echo.yaml b/.github/workflows/examples_echo.yaml index 7359a43bc..89aa1645c 100644 --- a/.github/workflows/examples_echo.yaml +++ b/.github/workflows/examples_echo.yaml @@ -7,6 +7,7 @@ concurrency: on: pull_request: paths: + - "examples/echo/pubspec.yaml" - "examples/echo/routes/**" - "examples/echo/lib/**" - "examples/echo/test/**" diff --git a/.github/workflows/examples_hello_world.yaml b/.github/workflows/examples_hello_world.yaml index b3755a631..ce5685231 100644 --- a/.github/workflows/examples_hello_world.yaml +++ b/.github/workflows/examples_hello_world.yaml @@ -7,7 +7,7 @@ concurrency: on: pull_request: paths: - - "examples/hello_world/routes/**" + - "examples/hello_world/pubspec.yaml" - "examples/hello_world/lib/**" - "examples/hello_world/test/**" - "examples/hello_world/e2e/**" diff --git a/.github/workflows/examples_kitchen_sink.yaml b/.github/workflows/examples_kitchen_sink.yaml index c57a01fe7..ad3737e6f 100644 --- a/.github/workflows/examples_kitchen_sink.yaml +++ b/.github/workflows/examples_kitchen_sink.yaml @@ -7,6 +7,7 @@ concurrency: on: pull_request: paths: + - "examples/kitchen_sink/pubspec.yaml" - "examples/kitchen_sink/routes/**" - "examples/kitchen_sink/lib/**" - "examples/kitchen_sink/test/**" diff --git a/.github/workflows/examples_todos.yaml b/.github/workflows/examples_todos.yaml index fb9d585a7..ea91edef3 100644 --- a/.github/workflows/examples_todos.yaml +++ b/.github/workflows/examples_todos.yaml @@ -7,9 +7,11 @@ concurrency: on: pull_request: paths: + - "examples/todos/pubspec.yaml" - "examples/todos/routes/**" - "examples/todos/lib/**" - "examples/todos/test/**" + - "examples/todos/packages/**/pubspec.yaml" - "examples/todos/packages/**/lib/**" - "examples/todos/packages/**/test/**" - "examples/todos/packages/**/e2e/**" diff --git a/.github/workflows/examples_web_socket_counter.yaml b/.github/workflows/examples_web_socket_counter.yaml index f06ebeca0..5ea4b8b46 100644 --- a/.github/workflows/examples_web_socket_counter.yaml +++ b/.github/workflows/examples_web_socket_counter.yaml @@ -7,6 +7,7 @@ concurrency: on: pull_request: paths: + - "examples/web_socket_counter/pubspec.yaml" - "examples/web_socket_counter/routes/**" - "examples/web_socket_counter/lib/**" - "examples/web_socket_counter/test/**" diff --git a/examples/counter/analysis_options.yaml b/examples/counter/analysis_options.yaml index be1bce24e..c7627ffd8 100644 --- a/examples/counter/analysis_options.yaml +++ b/examples/counter/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml analyzer: exclude: - build/** diff --git a/examples/counter/pubspec.yaml b/examples/counter/pubspec.yaml index b91019158..7bb17bcbe 100644 --- a/examples/counter/pubspec.yaml +++ b/examples/counter/pubspec.yaml @@ -13,4 +13,4 @@ dev_dependencies: http: ^0.13.5 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/echo/analysis_options.yaml b/examples/echo/analysis_options.yaml index be1bce24e..c7627ffd8 100644 --- a/examples/echo/analysis_options.yaml +++ b/examples/echo/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml analyzer: exclude: - build/** diff --git a/examples/echo/pubspec.yaml b/examples/echo/pubspec.yaml index 353fb7fec..e34af1d9f 100644 --- a/examples/echo/pubspec.yaml +++ b/examples/echo/pubspec.yaml @@ -13,4 +13,4 @@ dev_dependencies: http: ^0.13.5 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/hello_world/analysis_options.yaml b/examples/hello_world/analysis_options.yaml index be1bce24e..c7627ffd8 100644 --- a/examples/hello_world/analysis_options.yaml +++ b/examples/hello_world/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml analyzer: exclude: - build/** diff --git a/examples/hello_world/pubspec.yaml b/examples/hello_world/pubspec.yaml index 7a6ee1b26..91fdf4b9b 100644 --- a/examples/hello_world/pubspec.yaml +++ b/examples/hello_world/pubspec.yaml @@ -13,4 +13,4 @@ dev_dependencies: http: ^0.13.5 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/kitchen_sink/analysis_options.yaml b/examples/kitchen_sink/analysis_options.yaml index be1bce24e..c7627ffd8 100644 --- a/examples/kitchen_sink/analysis_options.yaml +++ b/examples/kitchen_sink/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml analyzer: exclude: - build/** diff --git a/examples/kitchen_sink/pubspec.yaml b/examples/kitchen_sink/pubspec.yaml index bb15cf7cd..27bc7d3af 100644 --- a/examples/kitchen_sink/pubspec.yaml +++ b/examples/kitchen_sink/pubspec.yaml @@ -13,4 +13,4 @@ dev_dependencies: http: ^0.13.5 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/todos/analysis_options.yaml b/examples/todos/analysis_options.yaml index be1bce24e..c7627ffd8 100644 --- a/examples/todos/analysis_options.yaml +++ b/examples/todos/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml analyzer: exclude: - build/** diff --git a/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml b/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml index 273cb60f9..84e34fba4 100644 --- a/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml +++ b/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml diff --git a/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml b/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml index b1b2e8310..a32fb377e 100644 --- a/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml +++ b/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml @@ -4,7 +4,7 @@ version: 0.1.0+1 publish_to: none environment: - sdk: ">=2.17.0 <3.0.0" + sdk: ">=2.19.0 <3.0.0" dependencies: todos_data_source: @@ -14,4 +14,4 @@ dependencies: dev_dependencies: mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/todos/packages/todos_data_source/analysis_options.yaml b/examples/todos/packages/todos_data_source/analysis_options.yaml index 273cb60f9..84e34fba4 100644 --- a/examples/todos/packages/todos_data_source/analysis_options.yaml +++ b/examples/todos/packages/todos_data_source/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml diff --git a/examples/todos/packages/todos_data_source/lib/src/models/todo.dart b/examples/todos/packages/todos_data_source/lib/src/models/todo.dart index 67c72a117..7717961b5 100644 --- a/examples/todos/packages/todos_data_source/lib/src/models/todo.dart +++ b/examples/todos/packages/todos_data_source/lib/src/models/todo.dart @@ -22,8 +22,8 @@ part 'todo.g.dart'; class Todo extends Equatable { /// {@macro `todo`} Todo({ - this.id, required this.title, + this.id, this.description = '', this.isCompleted = false, }) : assert(id == null || id.isNotEmpty, 'id cannot be empty'); diff --git a/examples/todos/packages/todos_data_source/pubspec.yaml b/examples/todos/packages/todos_data_source/pubspec.yaml index 88d2d9dae..c575429a8 100644 --- a/examples/todos/packages/todos_data_source/pubspec.yaml +++ b/examples/todos/packages/todos_data_source/pubspec.yaml @@ -4,7 +4,7 @@ version: 0.1.0+1 publish_to: none environment: - sdk: ">=2.17.0 <3.0.0" + sdk: ">=2.19.0 <3.0.0" dependencies: equatable: ^2.0.3 @@ -16,4 +16,4 @@ dev_dependencies: json_serializable: ^6.3.1 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/todos/pubspec.yaml b/examples/todos/pubspec.yaml index 55788c791..c8b006d90 100644 --- a/examples/todos/pubspec.yaml +++ b/examples/todos/pubspec.yaml @@ -17,4 +17,4 @@ dev_dependencies: http: ^0.13.5 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 diff --git a/examples/web_socket_counter/analysis_options.yaml b/examples/web_socket_counter/analysis_options.yaml index be1bce24e..c7627ffd8 100644 --- a/examples/web_socket_counter/analysis_options.yaml +++ b/examples/web_socket_counter/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.3.1.0.yaml +include: package:very_good_analysis/analysis_options.4.0.0.yaml analyzer: exclude: - build/** diff --git a/examples/web_socket_counter/pubspec.yaml b/examples/web_socket_counter/pubspec.yaml index d254f7e34..f7d1572d3 100644 --- a/examples/web_socket_counter/pubspec.yaml +++ b/examples/web_socket_counter/pubspec.yaml @@ -16,5 +16,5 @@ dev_dependencies: http: ^0.13.5 mocktail: ^0.3.0 test: ^1.19.2 - very_good_analysis: ^3.1.0 + very_good_analysis: ^4.0.0 web_socket_client: ^0.1.0-dev.1