Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable to fix #1845 #1846

Closed
wants to merge 1 commit into from
Closed

Add env variable to fix #1845 #1846

wants to merge 1 commit into from

Conversation

cropalato
Copy link

@cropalato cropalato commented May 8, 2023

  • Add PROMETHEUS_TEXT_KEY
  • Use PROMETHEUS_TEXT_KEY to override text default value.

Description
The users will be able to use the environment variable PROMETHEUS_TEXT_KEY to redefine the text that "Alerta" will display as a description.

Fixes #1845

Changes
Include a brief summary of changes...

  • Get value from environment variable PROMETHEUS_TEXT_KEY or config file;
  • In case the variable is defined, it will override the default value

Checklist

  • [ x] Pull request is limited to a single purpose
  • [ x] Code style/formatting is consistent
  • [ x] All existing tests are passing
  • Added new tests related to the change
  • [ x] No unnecessary whitespace changes

Collaboration
When a user creates a pull request from a fork that they own, the user
generally has the authority to decide if other users can commit to the
pull request's compare branch. If the pull request author wants greater
collaboration, they can grant maintainers of the upstream repository
(that is, anyone with push access to the upstream repository) permission
to commit to the pull request's compare branch

See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

- Add PROMETHEUS_TEXT_KEY
- Use PROMETHEUS_TEXT_KEY to override text default value.
@satterly satterly added the needs work This pull request needs work label Jun 25, 2023
@cropalato cropalato closed this by deleting the head repository Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work This pull request needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a custom annotation key as text description for an alert
2 participants