New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insertion of big block #160
Comments
Hey @tdroxler, just like how you found, Postgres allows This commit fixes this by adding the ability to split a query into 2 or more queries when parameter size grows over Eg: for queries with one parameter per row
Alternatively a simpler approach would be to revert back to how Slick's typed queries did batch insert i.e. single row per insert.
I can run benchmarks to see if there is a performance difference. What do you think? |
The error was: Let's start with your solution and as we discussed, if we feel at some point that we need some optimization we can run the various benchmarks. |
When we insert a big block, we create too many bind variable for postgres' prepared statement.
The issue is shown in that branch:
feature/insert-big-block
just run:
app/testOnly org.alephium.explorer.persistence.dao.BlockDaoSpec -- -z "insert big block"
The text was updated successfully, but these errors were encountered: