Allow custom & union productions #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccolljr
commented
Jun 12, 2022
mccolljr
commented
Jun 12, 2022
mccolljr
commented
Jun 12, 2022
mccolljr
commented
Jun 12, 2022
mccolljr
commented
Jun 12, 2022
alecthomas
approved these changes
Jun 12, 2022
|
Updated naming and documentation, and converted the fat tests to examples. Also added some smaller tests to the main tests suite just to make sure we're covering the new functionality. |
alecthomas
approved these changes
Jun 13, 2022
| // In most cases, using MaxLookahead will achieve the same results in practice, | ||
| // but with a concrete upper bound to prevent pathological behavior in the parser. | ||
| // Using infinite lookahead can be useful for testing, or for parsing especially | ||
| // ambiguous grammars. Use at your own risk! |
| // | ||
| // If the first member matches A, and the second member matches A B, | ||
| // and he source string is "AB", then the parser will only match A, and will not | ||
| // try to parse the second member at all. |
|
This is awesome, thanks for coordinating with me to get this merged so quickly! |
|
Thanks for doing the work :) PS. I updated the README, and made one minor change: renamed the |
Saw that - that's a fine change, naming is hard 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will eventually provide an implementation of "custom" productions (a custom parsing function that can parse any arbitrary go value), and "union" productions, which parse a single value from a set of possible values into a container of a single interface type.
The details regarding API and ergonomics will need to be fleshed out further before this can be merged.