Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing elements in Go Template lexer #387

Closed
malcom opened this issue Aug 3, 2020 · 2 comments
Closed

Missing elements in Go Template lexer #387

malcom opened this issue Aug 3, 2020 · 2 comments
Labels
help wanted lexer enhancement Lexer works but is not featureful

Comments

@malcom
Copy link

malcom commented Aug 3, 2020

Seems that the Go Template lexer do not support all "features" like assigned operator and multi-line comments. These elements in the rendered output are ignored and/or marked as a syntax error.

Code:

{{/* a comment */}}

{{/* a multi-line
comment
*/}}

{{ $variable := 1 }}
{{ $variable = 2 }}

Output:
image

@alecthomas alecthomas added help wanted lexer enhancement Lexer works but is not featureful labels Aug 30, 2020
@cmaster11
Copy link
Contributor

cmaster11 commented Sep 22, 2020

Addressed in #401 :)

@alecthomas
Copy link
Owner

Champion, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted lexer enhancement Lexer works but is not featureful
Projects
None yet
Development

No branches or pull requests

3 participants