From 98e5e5ef0e1502cf539f9ba48bcd44be7d10d022 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Mon, 27 Sep 2021 11:30:38 -0700 Subject: [PATCH] fix: don't overwrite default options unless given new value (#5111) --- packages/vite/src/node/build.ts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts index f11046c97fec25..df707be2e85657 100644 --- a/packages/vite/src/node/build.ts +++ b/packages/vite/src/node/build.ts @@ -234,16 +234,6 @@ export function resolveBuildOptions(raw?: BuildOptions): ResolvedBuildOptions { cssCodeSplit: !raw?.lib, sourcemap: false, rollupOptions: {}, - commonjsOptions: { - include: [/node_modules/], - extensions: ['.js', '.cjs'], - ...raw?.commonjsOptions - }, - dynamicImportVarsOptions: { - warnOnError: true, - exclude: [/node_modules/], - ...raw?.dynamicImportVarsOptions - }, minify: raw?.ssr ? false : 'esbuild', terserOptions: {}, write: true, @@ -256,7 +246,17 @@ export function resolveBuildOptions(raw?: BuildOptions): ResolvedBuildOptions { // brotliSize: true, chunkSizeWarningLimit: 500, watch: null, - ...raw + ...raw, + commonjsOptions: { + include: [/node_modules/], + extensions: ['.js', '.cjs'], + ...raw?.commonjsOptions + }, + dynamicImportVarsOptions: { + warnOnError: true, + exclude: [/node_modules/], + ...raw?.dynamicImportVarsOptions + } } // handle special build targets