New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for save and get raw definition #395
Conversation
3ce83a8
to
8cac620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, other than one inline suggestion, but please also document this in the readme with example code. Maybe a new "Getting the Raw Schema Definition" section under the Defining a Schema heading?
And add two tests in package/lib/SimpleSchema.tests.js
. One should pass no options and expect that rawDefinition
is null
. The other should pass { keepRawDefinition: true }
options and expect that rawDefinition
equals the definition object.
Thanks!
10ca1b9
to
63e969e
Compare
@aldeed I resolve all the observations. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Finished
🎉 This PR is included in version 1.11.0 🎉 The release is available on: If this makes you happy, please consider becoming a sponsor. Your semantic-release bot 📦🚀 |
Simple and conservative change to get the raw definition of the schema. related to #390 (comment)