Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for save and get raw definition #395

Merged
merged 6 commits into from Apr 8, 2021

Conversation

AndyCC25
Copy link
Contributor

Simple and conservative change to get the raw definition of the schema. related to #390 (comment)

Copy link
Collaborator

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, other than one inline suggestion, but please also document this in the readme with example code. Maybe a new "Getting the Raw Schema Definition" section under the Defining a Schema heading?

And add two tests in package/lib/SimpleSchema.tests.js. One should pass no options and expect that rawDefinition is null. The other should pass { keepRawDefinition: true } options and expect that rawDefinition equals the definition object.

Thanks!

package/lib/SimpleSchema.js Outdated Show resolved Hide resolved
@AndyCC25
Copy link
Contributor Author

Code looks good, other than one inline suggestion, but please also document this in the readme with example code. Maybe a new "Getting the Raw Schema Definition" section under the Defining a Schema heading?

And add two tests in package/lib/SimpleSchema.tests.js. One should pass no options and expect that rawDefinition is null. The other should pass { keepRawDefinition: true } options and expect that rawDefinition equals the definition object.

Thanks!

@aldeed I resolve all the observations. Thanks!!

@aldeed aldeed changed the base branch from master to main July 30, 2020 14:44
Copy link
Contributor Author

@AndyCC25 AndyCC25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Finished

@aldeed aldeed merged commit 3810591 into longshotlabs:main Apr 8, 2021
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

If this makes you happy, please consider becoming a sponsor.

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants