Skip to content

fix: do not create an array to pass in to uint8arraylist #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

achingbrain
Copy link
Collaborator

Tiny fix but there's no need to create an array and then immediately spread it, we can just pass the items in directly.

Tiny fix but there's no need to create an array and then immediately
spread it, we can just pass the items in directly.
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #22 (df05352) into master (a836df3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          14       14           
  Lines         885      885           
  Branches      136      136           
=======================================
  Hits          874      874           
  Misses         11       11           
Flag Coverage Δ
chrome 100.00% <ø> (ø)
node 98.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/encode.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06712fb...df05352. Read the comment docs.

@achingbrain achingbrain merged commit 94c4f03 into master Mar 8, 2022
@achingbrain achingbrain deleted the fix/uint8arraylist-args branch March 8, 2022 07:23
github-actions bot pushed a commit that referenced this pull request Mar 8, 2022
### [7.0.1](v7.0.0...v7.0.1) (2022-03-08)

### Bug Fixes

* do not create an array to pass in to uint8arraylist ([#22](#22)) ([94c4f03](94c4f03))
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant