Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt missing after a recent npm update #111

Open
mgol opened this issue Jul 11, 2016 · 5 comments
Open

prompt missing after a recent npm update #111

mgol opened this issue Jul 11, 2016 · 5 comments

Comments

@mgol
Copy link

mgol commented Jul 11, 2016

The prompt is missing after invoking those commands, both in bash & zsh:

$ npm -g i david@7.0.2
$ david

This is happening on OS X 10.11.5 in Terminal.app.

This is related to the new progress bar in npm 3.10.x. If I revert the internal david npm copy to the latest 3.9, it works fine. With npm 3.10 internally the only way to get the prompt back is to invoke some npm command that shows the new progress bar like npm install.

I'd report an issue to npm but npm itself cleans up after its own commands just fine... So I'm not sure if it's an npm issue or is david interacting with it in a weird way.

@jpaulin
Copy link
Contributor

jpaulin commented Aug 25, 2016

My guess: the spinning wheel (progress bar) uses ANSI codes so that depending on which "position" it was left in when exiting from npm, the prompt disappears? Or the same thing happening in David alone. Maybe it is really their interaction. Because interestingly, today I did a small fix into David and then though; "Oh my, now I fixed one thing, but I lose my cursor". After the initial surprise I found two things: first, it doesn't happen always. Second: I found this particular issue. Looking forward into the code, too..

@jpaulin
Copy link
Contributor

jpaulin commented Sep 7, 2016

@mgol By the way, is it that your whole prompt is missing after running 'david', or just the cursor?

@mgol
Copy link
Author

mgol commented Sep 7, 2016

Just the cursor.

@mgol
Copy link
Author

mgol commented Jan 24, 2017

In david 10.1.0 I don't see a progress bar and, therefore, the cursor no longer disappears. Was that an intended change or did sth change accidentally?

@jpaulin
Copy link
Contributor

jpaulin commented Jan 25, 2017

Indeed, fixed. I'm on Ubuntu 16.04 and using David from xterm terminal. No longer disappearing cursors. The 9.x.x and 10.1.0 versions have same dependencies, so I would guess it's the new code that fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants