Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/438 Add sorting to jmp charts #439

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Feature/438 Add sorting to jmp charts #439

merged 6 commits into from
Dec 1, 2023

Conversation

ifirmawan
Copy link
Collaborator

@ifirmawan ifirmawan commented Nov 16, 2023 •
edited

TODO/DONE

  • Add sorting to JMP charts in Table by updating data endpoint
  • Add sorting to JMP charts in the Stack bar chart by updating TabJMP component
  • Update backend test
  • Update frontend test

@ifirmawan ifirmawan self-assigned this Nov 16, 2023
@ifirmawan ifirmawan changed the base branch from main to develop November 16, 2023 04:01
@ifirmawan ifirmawan linked an issue Nov 16, 2023 that may be closed by this pull request
Add sorting to JMP charts #438
Open
2 tasks
dedenbangkit
dedenbangkit requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@dedenbangkit dedenbangkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wai-uganda doest have JMP chart tabs, please check other Instance too

@coveralls
Copy link

coveralls commented Dec 1, 2023 •
edited

Coverage Status

coverage: 78.974% (+0.002%) from 78.972%
when pulling 4b9fce0 on feature/438-add-sorting-to-jmp-charts
into 82cf0df on develop.

@ifirmawan
Copy link
Collaborator Author

wai-uganda doest have JMP chart tabs, please check other Instance too

Hi mas @dedenbangkit, at that time this branch was not following the landing page changes that why the JMP chart tabs don't exist. I've merged this branch with the develop branch, tested it, and now it's available. Thank you

@dedenbangkit dedenbangkit merged commit 1c0ed61 into develop Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sorting to JMP charts
3 participants
@ifirmawan @coveralls @dedenbangkit