Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/434 update landing pages #435

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Feature/434 update landing pages #435

merged 8 commits into from
Dec 1, 2023

Conversation

ifirmawan
Copy link
Collaborator

@ifirmawan ifirmawan commented Nov 14, 2023 •
edited

TODO/DONE

  • Replace the carousel with tabs containing a Pie chart
  • Create config for each instance
  • Implements Non-JMP Chart
  • Implements JMP Chart

@ifirmawan ifirmawan self-assigned this Nov 14, 2023
@ifirmawan ifirmawan changed the base branch from develop to main November 14, 2023 04:49
@ifirmawan ifirmawan force-pushed the feature/434-update-landing-pages branch from fad01ed to fc9700a Compare November 14, 2023 04:54
@coveralls
Copy link

coveralls commented Nov 14, 2023 •
edited

Coverage Status

coverage: 78.972%. remained the same
when pulling b446bb8 on feature/434-update-landing-pages
into a8a4bf7 on develop.

@ifirmawan
[#434] Initial changes overview section in Homepage
dcfac21 
This initial change aims to form a basic pattern of what modifications must be made in order to replace the carousel with a pie chart (JMP and non-JMP)

[#434] Fix linter in homepage
@ifirmawan
[#434] Update overview config for all instances
34f6609
@ifirmawan ifirmawan force-pushed the feature/434-update-landing-pages branch from fc9700a to 34f6609 Compare November 14, 2023 06:30
@ifirmawan ifirmawan changed the base branch from main to develop November 14, 2023 09:19
@ifirmawan ifirmawan linked an issue Nov 14, 2023 that may be closed by this pull request
Update landing pages #434
Open
4 tasks
@ifirmawan ifirmawan marked this pull request as ready for review November 14, 2023 10:39
@dedenbangkit dedenbangkit merged commit 82cf0df into develop Dec 1, 2023
3 checks passed
@dedenbangkit dedenbangkit deleted the feature/434-update-landing-pages branch December 1, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update landing pages
3 participants
@ifirmawan @coveralls @dedenbangkit