Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#378] Fix Legend MainMap not appearing in FE #379

Merged

Conversation

ifirmawan
Copy link
Collaborator

@ifirmawan ifirmawan commented Jul 5, 2023

TODO/DONE

Changes log

Front-end MainMap

  • Remove conditional scoreOptions?.length because not all types of maps have JMP scores.
  • In order to handle scoreOptions we just add it separately and find markerOptions that don't have an option.
  • Check form switching by checking loadedFormId and current.formId are the same or not
  • Add (!_.isEqual(opts1, opts2)) to avoid memory leak

Joy's Request

Add map indicator - WAI Ethiopia

  • Waterpoint : Water Source Type , Functionality Status
  • CLTS : Open Defecation Status, Implementing Partner

@ifirmawan ifirmawan self-assigned this Jul 5, 2023
@ifirmawan ifirmawan linked an issue Jul 5, 2023 that may be closed by this pull request
1 task
@dedenbangkit dedenbangkit merged commit cd487c2 into develop Jul 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WAI Ethiopia legend does not appear
2 participants