Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestKit] SupervisorStrategy for TestActor is unused #7062

Open
roee88 opened this issue Jan 14, 2024 · 1 comment
Open

[TestKit] SupervisorStrategy for TestActor is unused #7062

roee88 opened this issue Jan 14, 2024 · 1 comment
Milestone

Comments

@roee88
Copy link

roee88 commented Jan 14, 2024

Version Information

v1.5

Describe the bug

#4148 added public IActorRef ChildActorOf(Props props, string name, SupervisorStrategy supervisorStrategy) and similar methods to TestKitBase. However, the supervisorStrategy does not take effect.

It looks like InternalTestActor doesn't override SupervisorStrategy() to actually use its private _supervisorStrategy. See

private DelegatingSupervisorStrategy _supervisorStrategy = new();

@Aaronontheweb Aaronontheweb added this to the 1.5.16 milestone Jan 16, 2024
@Aaronontheweb
Copy link
Member

Thanks, we'll look into this

@Aaronontheweb Aaronontheweb modified the milestones: 1.5.16, 1.5.17 Jan 31, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.17, 1.5.18 Mar 5, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.18, 1.5.19 Mar 12, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.19, 1.5.20 Apr 15, 2024
@Aaronontheweb Aaronontheweb modified the milestones: 1.5.20, 1.5.21 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants