Skip to content

Add dangerous type blacklist feature to Akka.Serialization.Hyperion #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 17, 2021
Merged

Add dangerous type blacklist feature to Akka.Serialization.Hyperion #5208

merged 7 commits into from
Aug 17, 2021

Conversation

Arkatufus
Copy link
Contributor

No description provided.

@Arkatufus
Add deserialization type blacklist security feature

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
28e0701
@Arkatufus
Add spec

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
e6e92b0
Aaronontheweb
Aaronontheweb requested changes Aug 17, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

docs/articles/networking/serialization.md
akka.actor.serialization-settings.hyperion.disallow-unsafe-type = false
```

> [!WARNING]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok good, you covered this here.

Aaronontheweb
Aaronontheweb approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work. We'll update this again once we cover this for Newtonsoft.Json in a future release.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) August 17, 2021 19:36
@Aaronontheweb Aaronontheweb mentioned this pull request Aug 17, 2021
Open
3 tasks
@Aaronontheweb Aaronontheweb merged commit 9364bdc into akkadotnet:dev Aug 17, 2021
@Aaronontheweb Aaronontheweb mentioned this pull request Jan 14, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb

Assignees
No one assigned
Labels
security serialization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb